SUGGESTED FIX



Name: pzR10082			Date: 10/09/2003


*** /net/crown/export1/zpm/webrev/src/share/classes/com/sun/java/swing/plaf/gtk/GTKFileChooserUI.java-	Wed Oct  8 18:43:30 2003
--- GTKFileChooserUI.java	Wed Oct  8 18:34:14 2003
***************
*** 716,721 ****
--- 716,734 ----
  	    setText(getFileChooser().getName((File) value));
  	    return this;
  	}
+ 
+         public boolean isOpaque() { 
+             Color back = getBackground();
+             Component p = getParent(); 
+             if (p != null) { 
+                 p = p.getParent(); 
+             }
+             // p should now be the JList. 
+             boolean colorMatch = (back != null) && (p != null) && 
+                 back.equals(p.getBackground()) && 
+                             p.isOpaque();
+             return !colorMatch && super.isOpaque(); 
+         }
      }
  
      protected class DirectoryCellRenderer extends DefaultListCellRenderer  {
***************
*** 726,731 ****
--- 739,757 ----
  	    setText(getFileChooser().getName((File) value) + "/");
  	    return this;
  	}
+ 
+         public boolean isOpaque() { 
+             Color back = getBackground();
+             Component p = getParent(); 
+             if (p != null) { 
+                 p = p.getParent(); 
+             }
+             // p should now be the JList. 
+             boolean colorMatch = (back != null) && (p != null) && 
+                 back.equals(p.getBackground()) && 
+                             p.isOpaque();
+             return !colorMatch && super.isOpaque(); 
+         }
      }
  
      public Dimension getPreferredSize(JComponent c) {

###@###.###

======================================================================
                                     

EVALUATION



Name: omR10226			Date: 09/08/2003

The bug is non-reproducible with Tiger. I'll close bug as
not reproducible.


======================================================================

Name: pzR10082			Date: 10/08/2003


Fix for 4787464 has fixed this problem in Tiger by overriding 
DefaultListCellRenderer.isOpaque(). The overriden method returns false
for cell renderers so their background is not painted. Porting this
fix back into 1.4.2_03 may be risky, so we may just override isOpaque()
in two GTKFileChooser inner classes: FileCellRenderer and 
DirectoryCellRenderer.

###@###.###

======================================================================
                                     

CONVERTED DATA

BugTraq+ Release Management Values

COMMIT TO FIX:
1.4.2_04

FIXED IN:
1.4.2_04

INTEGRATED IN:
1.4.2_04