The ModelMBean DescriptorSupport implementation of equals & hascode is sub optimal.

   // XXXX TODO: This is not very efficient! 
    public synchronized boolean equals(Object o) {
        if (o == this)
            return true;
        
        return new ImmutableDescriptor(descriptorMap).equals(o);
    }

    // XXXX TODO: This is not very efficient! 
    public synchronized int hashCode() {
        return new ImmutableDescriptor(descriptorMap).hashCode();
    }
Posted Date : 2006-03-22 17:30:29.0

N/A

I am not sure that DescriptorSupport instances will often be compared against objects that are not Descriptors.  However, the equals and hashCode implementations from ImmutableDescriptor could be factored out so that DescriptorSupport can use them without having to construct an ImmutableDescriptor.
Posted Date : 2006-03-23 15:21:55.0