Java Solaris Communities Sun Store Join SDN My Profile Why Join?
 
Bug Database
Bug Detail
Quick Lists
Top 25 Bugs
Top 25 RFE's
Recently Closed Bugs
Printable Page Printable Page


Bug Database
Bug ID: 6631437
Votes 0
Synopsis File{In,Out}putStream minor improvements to spec and stylistic improvements to code
Category java:classes_io
Reported Against
Release Fixed 7(b25)
State 10-Fix Delivered, bug
Priority: 3-Medium
Related Bugs
Submit Date 19-NOV-2007
Description
The links
{link java.io.FileDescriptor#valid() invalid}
need an extra "@".

FileOutputStream constructors are inconsistent,
sometimes referring to "file output stream", and
sometimes to "output file stream".

Fields that can be made final should be.

The following comment seems to be divorced from reality.
     /**
-     * The system dependent file descriptor. The value is
-     * 1 more than actual file descriptor. This means that
-     * the default value 0 indicates that the file is not open.
+     * The system dependent file descriptor.
      */

It's considered very bad style to refer to static fields through
instance syntax.

     protected void finalize() throws IOException {
-	if ((fd != null) &&  (fd != fd.in)) {
-
+	if ((fd != null) &&  (fd != FileDescriptor.in)) {
 	    /*
Posted Date : 2007-11-19 05:16:51.0
Work Around
N/A
Evaluation
Yes.
Posted Date : 2007-11-19 05:16:51.0
Comments
  
  Include a link with my name & email   


PLEASE NOTE: JDK6 is formerly known as Project Mustang