|
Evaluation
|
I have only looked at this on Windows, but I have been able to reproduce this on
b11 (intermittently), so it's not a PIT bug.
I think this is a bug in the test, highlighted (on windows) by
the new on-screen rendering mechanism in the D3D pipeline.
The test paints the frame on the EDT but takes the
screen-shot from another thread.
Depending on the timings it may get a screen shot of
something it didn't expect.
Posted Date : 2008-02-14 21:29:46.0
Also, the test fails on solaris-sparc (Solaris 10) on 6u4 and earlier
releases. The reason it fails is
that the screen shot takes gnome's toolbar as well, and the test
attempts to check the pixels in the lower right and left corners.
The test should calculate the proper bounds for the screenshot
by checking the screen insets.
Posted Date : 2008-02-14 21:44:46.0
To determine exactly why it fails on a particular system, add this
code which'll dump the screenshot into Test.png:
*** /tmp/sccs.cuaaJW Thu Feb 14 13:49:42 2008
--- FSFrame.java Thu Feb 14 13:39:03 2008
***************
*** 65,70 ****
--- 65,75 ----
colorCorrect &= checkColor(getWidth() - 1, getHeight() - 1, bImg);
colorCorrect &= checkColor(getWidth() / 2, getHeight() / 2, bImg);
if (!colorCorrect) {
+ try {
+ javax.imageio.ImageIO.write(bImg, "png", new java.io.File("Test.png"));
+ } catch (Exception e) {
+ System.err.println(e);
+ }
throw new Error("Some pixel colors not correct; FS window may not" +
" have been displayed correctly");
}
Posted Date : 2008-02-14 21:50:48.0
It seems the test fails on solaris because of the problem described in 6500686 and should be corrected.
Posted Date : 2008-02-27 13:24:40.0
I have updated the test to be more considerate.
The changes include:
- painting and taking the screenshot on the EDT
- if the full-screen mode is not supported, adjust the
bounds of the screenshot using screen's insets
Toolkit.getScreenInsets(GC) - since the window may not
overlap WM decorations if the fs is
not supported - like when the security manager is set
- dump the screenshot if the test fails
Note that the test may may still fail on older (pre 2.6?) gnome versions
because of Gnome bugs (like it does on Solaris 10) - the screen insets
reported on Solaris 10 (JDS3) are 0x0x0x0 while they're clearly not.
(it would be nice to get a definite answer about this from AWT)
If the test does fail please consult the screenshot. If it shows
parts of the desktop decorations (taskbar, menubar) it is likely to
be a gnome issue.
Posted Date : 2008-02-27 20:42:38.0
|
