It appears that the Makefiles are using ifdef OPENJDK, but are not catching when someone sets it to false.

Probably should use ifeq ($(OPENJDK),true) and guarantee that it is either true or false at sanity time.
Posted Date : 2008-03-12 00:48:53.0

N/A

Change makefiles to use ifeq and be explicit for value true or false.
Posted Date : 2008-03-13 01:28:52.0

diff --git a/make/common/Defs.gmk b/make/common/Defs.gmk
--- a/make/common/Defs.gmk
+++ b/make/common/Defs.gmk
@@ -89,14 +89,8 @@ endif
 
 # Check for strange explicit settings (change to empty or true)
 ifdef OPENJDK
-  ifeq ($(OPENJDK),false)
-    # Silently treat as not defined
-    OPENJDK =
-  else
-    ifneq ($(OPENJDK),true)
-      dummy := $(warning "WARNING: OPENKJDK=$(OPENJDK) being treated as true")
-      OPENJDK = true
-    endif
+  ifneq ($(OPENJDK),true)
+    x:=$(error "OPENJDK can only be set to true")
   endif
 endif
 

Top level makefiles:

diff --git a/make/Defs-internal.gmk b/make/Defs-internal.gmk
--- a/make/Defs-internal.gmk
+++ b/make/Defs-internal.gmk
@@ -100,6 +100,11 @@ ifeq ($(JDK_SRC_AVAILABLE),true)
     ifeq ($(JDK_CLOSED_SRC_AVAILABLE),false)
       OPENJDK = true
     endif
+  endif
+endif
+ifdef OPENJDK
+  ifneq ($(OPENJDK),true)
+    x:=$(error "OPENJDK can only be set to true")
   endif
 endif
Posted Date : 2008-03-13 04:46:29.0

http://hg.openjdk.java.net/jdk7/build/jdk/rev/ea98209ac149
http://hg.openjdk.java.net/jdk7/build/rev/05809a7eb190
Posted Date : 2008-03-18 19:36:03.0