United StatesChange Country, Oracle Worldwide Web Sites Communities I am a... I want to...
Bug ID: 6876584 parameters order is incorrect for enc_String_Equals() in x86_32.ad
6876584 : parameters order is incorrect for enc_String_Equals() in x86_32.ad

Details
Type:
Bug
Submit Date:
2009-08-27
Status:
Resolved
Updated Date:
2010-04-03
Project Name:
JDK
Resolved Date:
2009-09-09
Component:
hotspot
OS:
solaris
Sub-Component:
compiler
CPU:
x86
Priority:
P4
Resolution:
Fixed
Affected Versions:
hs16
Fixed Versions:
hs16

Related Reports
Backport:
JDK-2182827 - parameters order is incorrect for enc_String_Equals() in x86_32.ad

Sub Tasks

Description
In instruction string_equals()
   ins_encode( enc_String_Equals(tmp1, tmp2, str1, str2, tmp3, tmp4, result) );

but declaration 
  enc_class enc_String_Equals(eDIRegP str1, eSIRegP str2, regXD tmp1, regXD tmp2,
                       eBXRegI tmp3, eCXRegI tmp4, eAXRegI result) %{

Comments
EVALUATION

http://hg.openjdk.java.net/hsx/hsx16/master/rev/74453a25211d
2009-09-04 
EVALUATION

http://hg.openjdk.java.net/hsx/hsx16/baseline/rev/74453a25211d
2009-08-28 
PUBLIC COMMENTS

Fixed parameters order for enc_String_Equals(),
I forgot to fix it in 6875866.
Fixed typo in the comments in 6875866 changes.
Used shrq/addq in enc_String_IndexOf() in x86_64.ad
to be consistent with following code.
Added required /othervm to the 6875866 test.
2009-08-28


Hardware and Software, Engineered to Work Together