United StatesChange Country, Oracle Worldwide Web Sites Communities I am a... I want to...
Bug ID: 6951923 some uses of fatal1 were missed by 6888954
6951923 : some uses of fatal1 were missed by 6888954

Details
Type:
Bug
Submit Date:
2010-05-14
Status:
Closed
Updated Date:
2012-10-08
Project Name:
JDK
Resolved Date:
2010-05-18
Component:
hotspot
OS:
generic
Sub-Component:
runtime
CPU:
generic
Priority:
P4
Resolution:
Fixed
Affected Versions:
hs18
Fixed Versions:
hs19

Related Reports
Backport:
JDK-2193334 - some uses of fatal1 were missed by 6888954
Backport:
JDK-2197622 - some uses of fatal1 were missed by 6888954
Backport:
JDK-2197914 - some uses of fatal1 were missed by 6888954
Backport:
JDK-2199817 - some uses of fatal1 were missed by 6888954
Relates:
JDK-6888954 - argument formatting for assert() and friends

Sub Tasks

Description
From: Gary Benson <###@###.###> 
To: ###@###.### 
Subject: Review Request: 6888954 broke Zero 
Date: Wed, 12 May 2010 17:44:31 +0100 
 
Hi all, 
 
The commit for 6888954 broke Zero.  This webrev fixes: 
 
  http://cr.openjdk.java.net/~gbenson/6888954-broke-zero/ 
 
I don't have a bug id for this. 
 
Cheers, 
Gary

Comments
SUGGESTED FIX

--- old/hotspot/src/os_cpu/linux_zero/vm/os_linux_zero.cpp	2010-05-12 17:41:53.000000000 +0100
+++ new/hotspot/src/os_cpu/linux_zero/vm/os_linux_zero.cpp	2010-05-12 17:41:53.000000000 +0100
@@ -288,7 +288,7 @@
       vm_exit_out_of_memory(0, "pthread_getattr_np");
     }
     else {
-      fatal1("pthread_getattr_np failed with errno = %d", res);
+      fatal(err_msg("pthread_getattr_np failed with errno = %d", res));
     }
   }
 
@@ -296,7 +296,7 @@
   size_t stack_bytes;
   res = pthread_attr_getstack(&attr, (void **) &stack_bottom, &stack_bytes);
   if (res != 0) {
-    fatal1("pthread_attr_getstack failed with errno = %d", res);
+    fatal(err_msg("pthread_attr_getstack failed with errno = %d", res));
   }
   address stack_top = stack_bottom + stack_bytes;
 
@@ -308,7 +308,7 @@
   size_t guard_bytes;
   res = pthread_attr_getguardsize(&attr, &guard_bytes);
   if (res != 0) {
-    fatal1("pthread_attr_getguardsize failed with errno = %d", res);
+    fatal(err_msg("pthread_attr_getguardsize failed with errno = %d", res));
   }
   int guard_pages = align_size_up(guard_bytes, page_bytes) / page_bytes;
   assert(guard_bytes == guard_pages * page_bytes, "unaligned guard");
2010-05-14 
EVALUATION

6888954 removed the definition of fatal1, but uses still exist in os_linux_zero.cpp.
2010-05-14 
EVALUATION

http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/67d74f7a15d9
2010-05-14


Hardware and Software, Engineered to Work Together