United StatesChange Country, Oracle Worldwide Web Sites Communities I am a... I want to...
Bug ID: 6953952 collectedHeap.cpp should use #ifdef _LP64 not LP64
6953952 : collectedHeap.cpp should use #ifdef _LP64 not LP64

Details
Type:
Enhancement
Submit Date:
2010-05-19
Status:
Resolved
Updated Date:
2010-09-24
Project Name:
JDK
Resolved Date:
2010-06-01
Component:
hotspot
OS:
generic
Sub-Component:
gc
CPU:
generic
Priority:
P4
Resolution:
Fixed
Affected Versions:
hs19
Fixed Versions:
hs19

Related Reports
Backport:
Backport:
Backport:
Backport:
Relates:

Sub Tasks

Description
From email thread on openjdk:-

Vladimir Kozlov wrote:
> The file also have LP64 instead of _LP64:
>
> src/share/vm/gc_interface/collectedHeap.cpp:#ifdef LP64
>

Yes, that one is probably not fatal (as far as i can see because
i think LP64 gets defined when building 64-bit and this has been around
a lot longer than COMPLER2; i'll check), but we should fix that too...

thanks Vladimir.
-- ramki


> Vladimir
>
> Y. Srinivas Ramakrishna wrote:
>> 6953483 Typo related to ReduceInitialCardMarks
>>
>> Workaround for the case of CMS: -XX:-ReduceInitialCardMarks.
>>
>> No issue for other collectors (G1, which may otherwise have been
>> vulnerable, has this optimization switched off).
>>
>> Thanks, ChenGuang, for bringing this to our attention.
>> -- ramki
>>
>> Y. Srinivas Ramakrishna wrote:
>>> Looks like I am responsible for that typo (which is still there).
>>> I'll test and fix that issue. Thanks for the fix!
>>>
>>> -- ramki
>>>
>>> ChenGuang Sun wrote:
>>>> Hi,
>>>>
>>>>     I'm reading the code and have noticed a minor typo in the function
>>>> "CollectedHeap::pre_initialize()".
>>>>
>>>>     I think it should be "#ifdef COMPILER2" instead of "#ifdef
>>>> COMPLER2". I haven't checked whether it has been corrected in the
>>>> latest revision.
>>>>
>>>> Thanks,
>>>> Chen

                                    

Comments
EVALUATION

http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/1634cec09505
                                     
2010-05-20
WORK AROUND

None needed. This was just a matter of code hygiene, that's all.
                                     
2010-05-19
SUGGESTED FIX

diff -r 15190cbcabe9 src/share/vm/gc_interface/collectedHeap.cpp
--- a/src/share/vm/gc_interface/collectedHeap.cpp       Wed May 19 10:37:05 2010 -0700
+++ b/src/share/vm/gc_interface/collectedHeap.cpp       Wed May 19 11:34:30 2010 -0700
@@ -309,7 +309,7 @@ void CollectedHeap::fill_with_objects(He
   DEBUG_ONLY(fill_args_check(start, words);)
   HandleMark hm;  // Free handles before leaving.
 
-#ifdef LP64
+#ifdef _LP64
   // A single array can fill ~8G, so multiple objects are needed only in 64-bit.
   // First fill with arrays, ensuring that any remaining space is big enough to
   // fill.  The remainder is filled with a single object.
                                     
2010-05-19
EVALUATION

As in synopsis.
                                     
2010-05-19



Hardware and Software, Engineered to Work Together