United StatesChange Country, Oracle Worldwide Web Sites Communities I am a... I want to...
Bug ID: 6958485 fix for 6879921 was insufficient
6958485 : fix for 6879921 was insufficient

Details
Type:
Bug
Submit Date:
2010-06-04
Status:
Closed
Updated Date:
2011-03-08
Project Name:
JDK
Resolved Date:
2011-03-08
Component:
hotspot
OS:
solaris_9
Sub-Component:
compiler
CPU:
sparc
Priority:
P3
Resolution:
Fixed
Affected Versions:
hs17
Fixed Versions:
hs19

Related Reports
Backport:
Backport:
Backport:
Backport:
Relates:

Sub Tasks

Description
6879921 fix a case where it the superword optimization was attempting to handle arrays of oops which we didn't allow.  A guard was inserted in stmts_can_pack which fixed the original issue.  Testing with bigapps has shown that there are other paths where this problem can manifest.  In particular this pattern:

    public static void init(Object src[], boolean[] dst) {
        // initialize the arrays                                                                                                                      
        for (int i =0; i<src.length; i++) {
            dst[i] = src[i] != null ? false : true;
        }
    }

shows that are_adjacent_refs can be reached through est_savings, skipping the added is_java_primitive guard.  The fix is to move the is_java_primitive into are_adjacent_refs to guard the data_size calls.

                                    

Comments
EVALUATION

http://hg.openjdk.java.net/jdk7/hotspot-comp/hotspot/rev/49fac4acd688
                                     
2010-06-08



Hardware and Software, Engineered to Work Together