United StatesChange Country, Oracle Worldwide Web Sites Communities I am a... I want to...
Bug ID: 7053189 remove some unnecessary platform-dependent includes
7053189 : remove some unnecessary platform-dependent includes

Details
Type:
Enhancement
Submit Date:
2011-06-09
Status:
Closed
Updated Date:
2011-11-25
Project Name:
JDK
Resolved Date:
2011-09-30
Component:
hotspot
OS:
generic
Sub-Component:
build
CPU:
generic
Priority:
P4
Resolution:
Fixed
Affected Versions:
hs22
Fixed Versions:
hs22

Related Reports
Backport:
Backport:

Sub Tasks

Description
Some platform-dependent #includes in jni.cpp, arguments.cpp and atomic.cpp are unneeded and should be removed.

                                    

Comments
EVALUATION

http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/8a4fc2990229
                                     
2011-07-17
EVALUATION

http://hg.openjdk.java.net/hsx/hotspot-comp/hotspot/rev/8a4fc2990229
                                     
2011-07-13
EVALUATION

http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot/rev/8a4fc2990229
                                     
2011-07-08
SUGGESTED FIX

changeset:   2544:8a4fc2990229
tag:         tip
user:        jcoomes
date:        Thu Jul 07 15:44:34 2011 -0700
summary:     7053189: remove some unnecessary platform-dependent includes

diff -r bf6481e5f96d -r 8a4fc2990229 src/share/vm/prims/jni.cpp
--- a/src/share/vm/prims/jni.cpp	Wed Jul 06 13:02:54 2011 -0700
+++ b/src/share/vm/prims/jni.cpp	Thu Jul 07 15:44:34 2011 -0700
@@ -70,15 +70,6 @@
 #include "utilities/dtrace.hpp"
 #include "utilities/events.hpp"
 #include "utilities/histogram.hpp"
-#ifdef TARGET_ARCH_x86
-# include "jniTypes_x86.hpp"
-#endif
-#ifdef TARGET_ARCH_sparc
-# include "jniTypes_sparc.hpp"
-#endif
-#ifdef TARGET_ARCH_zero
-# include "jniTypes_zero.hpp"
-#endif
 #ifdef TARGET_OS_FAMILY_linux
 # include "os_linux.inline.hpp"
 # include "thread_linux.inline.hpp"
diff -r bf6481e5f96d -r 8a4fc2990229 src/share/vm/runtime/arguments.cpp
--- a/src/share/vm/runtime/arguments.cpp	Wed Jul 06 13:02:54 2011 -0700
+++ b/src/share/vm/runtime/arguments.cpp	Thu Jul 07 15:44:34 2011 -0700
@@ -37,15 +37,6 @@
 #include "services/management.hpp"
 #include "utilities/defaultStream.hpp"
 #include "utilities/taskqueue.hpp"
-#ifdef TARGET_ARCH_x86
-# include "vm_version_x86.hpp"
-#endif
-#ifdef TARGET_ARCH_sparc
-# include "vm_version_sparc.hpp"
-#endif
-#ifdef TARGET_ARCH_zero
-# include "vm_version_zero.hpp"
-#endif
 #ifdef TARGET_OS_FAMILY_linux
 # include "os_linux.inline.hpp"
 #endif
                                     
2011-06-09
EVALUATION

Builds work fine without the #includes, whether precompiled headers are used or not.
                                     
2011-06-09



Hardware and Software, Engineered to Work Together