EVALUATION

Treat 404 error in a special way and give it a try to alternative location.

Also in this change:
  - return installer exit code to javascript
  - distinguish between user canceled download vs network error
                                     

EVALUATION

problem is in src/plugin/win32/toolkit/common/JavaFX.cpp; we now never calls into the fallback into the secondary internal url.

309         // try external URL1, then internal URL2
 310         if (pInstallCallback->getPrimaryURL() != NULL) {
 311             if (dlg1.DoModal() == IDOK) {
 312                 // OK - we downloaded the external posted JavaFX intaller
 313                 if (ExecuteInstallation(szInsFile, "")) {
 314                     status = INSTALL_ERR_SUCCESS;
 315                 } else {
 316                     status = INSTALL_ERR_EXEC;
 317                 }
 318             } else {
 319                 //FIXME: return code other than IDOK, e.g. IDCANCEL, can be
 320                 // due to either canceled by the user or an error condition
 321                 // during download. Need to investigate on how to return an error
 322                 // code vs. user's cancellation from DownloadDialog.cpp.
 323                 status = INSTALL_ERR_DOWNLOAD;
 324             }
 325         } else {
 326             CDownloadDialog dlg2;
 327             dlg2.setInstallerURL(pInstallCallback->getSecondaryURL());  // try secondary URL