United StatesChange Country, Oracle Worldwide Web Sites Communities I am a... I want to...
Bug ID: 7140909 Visual Studio project builds broken: need to define INCLUDE_TRACE
7140909 : Visual Studio project builds broken: need to define INCLUDE_TRACE

Details
Type:
Bug
Submit Date:
2012-01-30
Status:
Resolved
Updated Date:
2012-03-22
Project Name:
JDK
Resolved Date:
2012-02-04
Component:
hotspot
OS:
generic
Sub-Component:
build
CPU:
generic
Priority:
P3
Resolution:
Fixed
Affected Versions:
hs23
Fixed Versions:
hs23

Related Reports
Backport:
JDK-2220946 - Visual Studio project builds broken: need to define INCLUDE_TRACE
Backport:
JDK-2220865 - Visual Studio project builds broken: need to define INCLUDE_TRACE
Relates:
JDK-7115199 - Add event tracing hooks and Java Flight Recorder infrastructure

Sub Tasks

Description
The fix for "7115199: Add event tracing hooks and Java Flight Recorder infrastructure" added this to make\windows\makefiles\vm.make:

!ifndef JAVASE_EMBEDDED
CPP_FLAGS=$(CPP_FLAGS) /D "INCLUDE_TRACE"
!endif

To keep the Visual Studio projects working the same type of change needs to be made to src\share\tools\ProjectCreator\BuildConfig.java

Comments
EVALUATION

http://hg.openjdk.java.net/lambda/lambda/hotspot/rev/2eeebe4b4213
2012-03-22 
EVALUATION

http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot/rev/2eeebe4b4213
2012-01-31 
EVALUATION

diff --git a/src/share/tools/ProjectCreator/BuildConfig.java b/src/share/tools/ProjectCreator/BuildConfig.java
--- a/src/share/tools/ProjectCreator/BuildConfig.java
+++ b/src/share/tools/ProjectCreator/BuildConfig.java
@@ -243,6 +243,7 @@
         sysDefines.add("_WINDOWS");
         sysDefines.add("HOTSPOT_BUILD_USER=\\\""+System.getProperty("user.name")+"\\\"");
         sysDefines.add("HOTSPOT_BUILD_TARGET=\\\""+get("Build")+"\\\"");
+        sysDefines.add("INCLUDE_TRACE");
         sysDefines.add("_JNI_IMPLEMENTATION_");
         if (vars.get("PlatformName").equals("Win32")) {
             sysDefines.add("HOTSPOT_LIB_ARCH=\\\"i386\\\"");
2012-01-30


Hardware and Software, Engineered to Work Together