EVALUATION
Changeset: 4d45c7117e23
Author: dcubed
Date: 2012-04-03 10:17 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/rev/4d45c7117e23
7157296: FDS: ENABLE_FULL_DEBUG_SYMBOLS flag should only affect OPT builds
Summary: Build option FULL_DEBUG_SYMBOLS=0 only affects OPT builds. Finish enabling ENABLE_FULL_DEBUG_SYMBOLS flag on Windows.
Reviewed-by: ohair, jmelvin, sspitsyn
! make/Defs-internal.gmk
! make/hotspot-rules.gmk
! make/jdk-rules.gmk
Changeset: 754945137012
Author: dcubed
Date: 2012-04-03 12:57 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/754945137012
7157296: FDS: ENABLE_FULL_DEBUG_SYMBOLS flag should only affect OPT builds
Summary: Build option FULL_DEBUG_SYMBOLS=0 only affects OPT builds. Finish enabling ENABLE_FULL_DEBUG_SYMBOLS flag on Windows.
Reviewed-by: ohair, jmelvin, sspitsyn
! make/common/Defs-linux.gmk
! make/common/Defs-solaris.gmk
! make/common/Defs-windows.gmk
! make/common/Library.gmk
! make/common/Program.gmk
|
SUGGESTED FIX
One late breaking change due to the corresponding install repo changes
not making it into JDK8-B33:
< diff -r e7f813f2ea86 make/common/Defs-linux.gmk
< --- a/make/common/Defs-linux.gmk Fri Mar 23 09:27:44 2012 -0700
< +++ b/make/common/Defs-linux.gmk Thu Mar 29 10:36:16 2012 -0700
---
> diff -r d0e8c9361bc0 make/common/Defs-linux.gmk
> --- a/make/common/Defs-linux.gmk Tue Apr 03 11:52:06 2012 +0900
> +++ b/make/common/Defs-linux.gmk Tue Apr 03 12:00:06 2012 -0700
42,44c42,55
< diff -r e7f813f2ea86 make/common/Defs-solaris.gmk
< --- a/make/common/Defs-solaris.gmk Fri Mar 23 09:27:44 2012 -0700
< +++ b/make/common/Defs-solaris.gmk Thu Mar 29 10:36:16 2012 -0700
---
> @@ -122,7 +151,9 @@ ifeq ($(ENABLE_FULL_DEBUG_SYMBOLS),1)
> _JUNK_ := $(shell \
> echo >&2 "INFO: STRIP_POLICY=$(STRIP_POLICY)")
>
> - ZIP_DEBUGINFO_FILES ?= 1
> + # HACK: disable ZIP_DEBUGINFO_FILES by default until install repo
> + # changes are promoted
> + ZIP_DEBUGINFO_FILES ?= 0
>
> _JUNK_ := $(shell \
> echo >&2 "INFO: ZIP_DEBUGINFO_FILES=$(ZIP_DEBUGINFO_FILES)")
> diff -r d0e8c9361bc0 make/common/Defs-solaris.gmk
> --- a/make/common/Defs-solaris.gmk Tue Apr 03 11:52:06 2012 +0900
> +++ b/make/common/Defs-solaris.gmk Tue Apr 03 12:00:06 2012 -0700
83,86c94,108
< diff -r e7f813f2ea86 make/common/Defs-windows.gmk
< --- a/make/common/Defs-windows.gmk Fri Mar 23 09:27:44 2012 -0700
< +++ b/make/common/Defs-windows.gmk Thu Mar 29 10:36:16 2012 -0700
< @@ -76,15 +76,43 @@ EXTRA_LFLAGS += /LIBPATH:$(DXSDK_LIB_PAT
---
> @@ -130,7 +159,9 @@ ifeq ($(ENABLE_FULL_DEBUG_SYMBOLS),1)
> _JUNK_ := $(shell \
> echo >&2 "INFO: STRIP_POLICY=$(STRIP_POLICY)")
>
> - ZIP_DEBUGINFO_FILES ?= 1
> + # HACK: disable ZIP_DEBUGINFO_FILES by default until install repo
> + # changes are promoted
> + ZIP_DEBUGINFO_FILES ?= 0
>
> _JUNK_ := $(shell \
> echo >&2 "INFO: ZIP_DEBUGINFO_FILES=$(ZIP_DEBUGINFO_FILES)")
> diff -r d0e8c9361bc0 make/common/Defs-windows.gmk
> --- a/make/common/Defs-windows.gmk Tue Apr 03 11:52:06 2012 +0900
> +++ b/make/common/Defs-windows.gmk Tue Apr 03 12:00:06 2012 -0700
> @@ -76,15 +76,45 @@ EXTRA_LFLAGS += /LIBPATH:$(DXSDK_LIB_PAT
124c146,149
< ZIP_DEBUGINFO_FILES ?= 1
---
> - ZIP_DEBUGINFO_FILES ?= 1
> + # HACK: disable ZIP_DEBUGINFO_FILES by default until install repo
> + # changes are promoted
> + ZIP_DEBUGINFO_FILES ?= 0
The above changes switch the default for ZIP_DEBUGINFO_FILES
from '1' to '0' because the current install repo cannot properly
handle the '.diz' files.
|
EVALUATION
The FULL_DEBUG_SYMBOLS build option should only affect OPT builds.
Non-OPT builds, i.e., debug builds, should have debug info otherwise
they are not much use.
This fix will push changes to the root repo, the deploy repo and
the jdk repo. The hotspot repo will make a similar fix via 7158067.
Since Windows has had Full Debug Symbols since JDK1.4.1, its FDS
support was always enabled. This fix will also make
FULL_DEBUG_SYMBOLS=0 work properly on Windows. Support for the
ZIP_DEBUGINFO_FILES flag on Windows will be done via 7071907.
|
Java