EVALUATION
For Windows, change the default ZIP_DEBUGINFO_FILES from '1' to '0'.
That disables .diz file creation by default and the tests that
were failing due to missing '.pdb' files should now pass.
For Solaris, change the default ZIP_DEBUGINFO_FILES from '1' to '0'.
Also change the default FULL_DEBUG_SYMBOLS from '1' to '0' because
unZIP'ed debug info files on Solaris have too big of an impact on
disk space footprint.
Since Linux testing didn't have any FDS failures, it looks like
Linux is OK with the new defaults.
|
SUGGESTED FIX
Context diff for the proposed fix:
diff -r 74c359c4a9e5 make/solaris/makefiles/defs.make
--- a/make/solaris/makefiles/defs.make Tue Apr 24 15:20:40 2012 -0700
+++ b/make/solaris/makefiles/defs.make Wed Apr 25 13:05:24 2012 -0700
@@ -109,12 +109,18 @@ ifeq ($(JDK6_OR_EARLIER),0)
# overridden in some situations, e.g., a BUILD_FLAVOR != product
# build.
+ # Disable FULL_DEBUG_SYMBOLS by default because dtrace tests are
+ # failing in nightly when the debug info files are ZIP'ed. On
+ # Solaris debug info files need to be ZIP'ed to reduce the impact
+ # on disk space footprint.
+ FULL_DEBUG_SYMBOLS ?= 0
ifeq ($(BUILD_FLAVOR), product)
- FULL_DEBUG_SYMBOLS ?= 1
+ # FULL_DEBUG_SYMBOLS ?= 1
ENABLE_FULL_DEBUG_SYMBOLS = $(FULL_DEBUG_SYMBOLS)
else
# debug variants always get Full Debug Symbols (if available)
- ENABLE_FULL_DEBUG_SYMBOLS = 1
+ # ENABLE_FULL_DEBUG_SYMBOLS = 1
+ ENABLE_FULL_DEBUG_SYMBOLS = $(FULL_DEBUG_SYMBOLS)
endif
_JUNK_ := $(shell \
echo >&2 "INFO: ENABLE_FULL_DEBUG_SYMBOLS=$(ENABLE_FULL_DEBUG_SYMBOLS)")
@@ -172,7 +178,9 @@ ifeq ($(JDK6_OR_EARLIER),0)
_JUNK_ := $(shell \
echo >&2 "INFO: STRIP_POLICY=$(STRIP_POLICY)")
- ZIP_DEBUGINFO_FILES ?= 1
+ # Disable ZIP_DEBUGINFO_FILES by default because dtrace tests are
+ # failing in nightly when the debug info files are ZIP'ed.
+ ZIP_DEBUGINFO_FILES ?= 0
_JUNK_ := $(shell \
echo >&2 "INFO: ZIP_DEBUGINFO_FILES=$(ZIP_DEBUGINFO_FILES)")
diff -r 74c359c4a9e5 make/windows/makefiles/defs.make
--- a/make/windows/makefiles/defs.make Tue Apr 24 15:20:40 2012 -0700
+++ b/make/windows/makefiles/defs.make Wed Apr 25 13:05:24 2012 -0700
@@ -143,7 +143,9 @@ MAKE_ARGS += ENABLE_FULL_DEBUG_SYMBOLS=$
MAKE_ARGS += ENABLE_FULL_DEBUG_SYMBOLS=$(ENABLE_FULL_DEBUG_SYMBOLS)
ifeq ($(ENABLE_FULL_DEBUG_SYMBOLS),1)
- ZIP_DEBUGINFO_FILES ?= 1
+ # Disable ZIP_DEBUGINFO_FILES by default because various tests are
+ # failing in nightly when the debug info files are ZIP'ed.
+ ZIP_DEBUGINFO_FILES ?= 0
else
ZIP_DEBUGINFO_FILES=0
endif
|