URL:   http://hg.openjdk.java.net/jdk8/build/jdk/rev/a51f86e2dce9
User:  katleman
Date:  2012-09-27 06:14:08 +0000

                                     

SUGGESTED FIX

Changeset: a51f86e2dce9
Author:    mullan
Date:      2012-09-10 08:57 -0400
URL:       http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a51f86e2dce9

7195301: XML Signature DOM implementation should not use instanceof to determine type of Node
Reviewed-by: xuelei

! src/share/classes/com/sun/org/apache/xml/internal/security/Init.java
! src/share/classes/com/sun/org/apache/xml/internal/security/c14n/implementations/CanonicalizerBase.java
! src/share/classes/com/sun/org/apache/xml/internal/security/encryption/XMLCipher.java
! src/share/classes/com/sun/org/apache/xml/internal/security/keys/keyresolver/implementations/RetrievalMethodResolver.java
! src/share/classes/com/sun/org/apache/xml/internal/security/utils/IdResolver.java
                                     

EVALUATION

There are a handful of places in the XML Signature implementation that use instanceof instead of Node.getNodeType(). These will all be modified to use Node.getNodeType(). Need to be also careful to check for null references before calling Node.getNodeType() to avoid NullPointerExceptions.