CONVERTED DATA

BugTraq+ Release Management Values

COMMIT TO FIX:
tiger-beta2

FIXED IN:
tiger-beta2

INTEGRATED IN:
tiger-b37
tiger-beta2

VERIFIED IN:
tiger-beta2


                                     

SUGGESTED FIX

The AD file was trying to stuff a long value into an 8bit immediate.  This was causing bits to be lost.  
###@###.### 2004-01-22

*** /home/azeem/public_html/webrev/cmp/src/cpu/ia64/vm/ia64.ad-	Tue Jan 27 14:57:20 2004
--- ia64.ad	Tue Jan 27 14:57:45 2004
***************
*** 1,6 ****
! // @(#)ia64.ad	1.106 04/01/15 15:45:59
  //
  // Copyright 2000-2002 Sun Microsystems, Inc.  All rights reserved.
  // SUN PROPRIETARY/CONFIDENTIAL.  Use is subject to license terms.
  //
  
--- 1,6 ----
! // @(#)ia64.ad	1.107 04/01/27 14:57:43
  //
  // Copyright 2000-2002 Sun Microsystems, Inc.  All rights reserved.
  // SUN PROPRIETARY/CONFIDENTIAL.  Use is subject to license terms.
  //
  
***************
*** 5074,5084 ****
    interface(CONST_INTER);
  %}
  
  // Integer Immediate: 8-bit
  operand immL8m1() %{
!   predicate(Assembler::is_simm8(n->get_long()-1));
    match(ConL);
  
    op_cost(5);
    format %{ %}
    interface(CONST_INTER);
--- 5074,5084 ----
    interface(CONST_INTER);
  %}
  
  // Integer Immediate: 8-bit
  operand immL8m1() %{
!   predicate((-127L <= n->get_long()) && (n->get_long() <= 128L));
    match(ConL);
  
    op_cost(5);
    format %{ %}
    interface(CONST_INTER);
***************
*** 11128,11138 ****
  %}
  
  instruct if_cmpL_reg_immL8(cmpOp cmp, gRegL src1, immL8 src2, label labl, pr6_pReg pr) %{
    match(If cmp (CmpL src1 src2));
    effect(USE cmp, USE src1, USE src2, USE labl, KILL pr);
!   predicate( _kids[0]->_leaf->is_Bool()->_test._test == BoolTest::eq || _kids[0]->_leaf->is_Bool()->_test._test == BoolTest::ne || _kids[0]->_leaf->is_Bool()->_test._test == BoolTest::gt || _kids[0]->_leaf->is_Bool()->_test._test == BoolTest::le );
    ins_cost(BRANCH_COST + DEFAULT_COST);
  
    format %{ "CMP.$cmp PR6,PR0=$src1,$src2\t// long\n\t(PR6) BR $labl" %}
    ins_encode( emit_cmp_reg_imm( cmp, PR6, PR0, src1, src2, PR0 ), emit_branch( labl, PR6 ) );
    ins_pipe(pr_pr_ICMP_gr_imm__BR_pr);
--- 11128,11141 ----
  %}
  
  instruct if_cmpL_reg_immL8(cmpOp cmp, gRegL src1, immL8 src2, label labl, pr6_pReg pr) %{
    match(If cmp (CmpL src1 src2));
    effect(USE cmp, USE src1, USE src2, USE labl, KILL pr);
!   predicate( _kids[0]->_leaf->is_Bool()->_test._test == BoolTest::eq || 
!              _kids[0]->_leaf->is_Bool()->_test._test == BoolTest::ne || 
!              _kids[0]->_leaf->is_Bool()->_test._test == BoolTest::gt || 
!              _kids[0]->_leaf->is_Bool()->_test._test == BoolTest::le );
    ins_cost(BRANCH_COST + DEFAULT_COST);
  
    format %{ "CMP.$cmp PR6,PR0=$src1,$src2\t// long\n\t(PR6) BR $labl" %}
    ins_encode( emit_cmp_reg_imm( cmp, PR6, PR0, src1, src2, PR0 ), emit_branch( labl, PR6 ) );
    ins_pipe(pr_pr_ICMP_gr_imm__BR_pr);
***************
*** 11140,11150 ****
  
  // Long branch on less than
  instruct if_cmpL_reg_immL8m1(cmpOp cmp, gRegL src1, immL8m1 src2, label labl, pr6_pReg pr) %{
    match(If cmp (CmpL src1 src2));
    effect(USE cmp, USE src1, USE src2, USE labl, KILL pr);
!   predicate( _kids[0]->_leaf->is_Bool()->_test._test == BoolTest::lt || _kids[0]->_leaf->is_Bool()->_test._test == BoolTest::ge );
    ins_cost(BRANCH_COST + DEFAULT_COST);
  
    format %{ "CMP.$cmp PR6,PR0=$src1,$src2\t// long\n\t(PR6) BR $labl" %}
    ins_encode( emit_cmp_reg_imm( cmp, PR6, PR0, src1, src2, PR0 ), emit_branch( labl, PR6 ) );
    ins_pipe(pr_pr_ICMP_gr_imm__BR_pr);
--- 11143,11154 ----
  
  // Long branch on less than
  instruct if_cmpL_reg_immL8m1(cmpOp cmp, gRegL src1, immL8m1 src2, label labl, pr6_pReg pr) %{
    match(If cmp (CmpL src1 src2));
    effect(USE cmp, USE src1, USE src2, USE labl, KILL pr);
!   predicate( _kids[0]->_leaf->is_Bool()->_test._test == BoolTest::lt || 
!              _kids[0]->_leaf->is_Bool()->_test._test == BoolTest::ge );
    ins_cost(BRANCH_COST + DEFAULT_COST);
  
    format %{ "CMP.$cmp PR6,PR0=$src1,$src2\t// long\n\t(PR6) BR $labl" %}
    ins_encode( emit_cmp_reg_imm( cmp, PR6, PR0, src1, src2, PR0 ), emit_branch( labl, PR6 ) );
    ins_pipe(pr_pr_ICMP_gr_imm__BR_pr);
###@###.### 2004-01-27
                                     

EVALUATION

I've verified the regression tests fail on a recent build on a local itanium machine.  All the failures are for double subnormal inputs.

The problem is apparently a code generation issue with the Itanium server compiler.  I wrote a simple stand-alone test program with some of the failing values.  When the short program was run without a vm option or with -Xint, the proper results are calculated.  However, the program fails when run with -Xcomp.

import sun.misc.FpUtils;
import sun.misc.DoubleConsts;

public class test {
    public static void main(String argv[]) {
	double [] values = {
	    Double.MIN_VALUE,
	    Double.MIN_VALUE*2,
	    Double.MIN_VALUE*3,
	    FpUtils.nextDown(DoubleConsts.MIN_NORMAL),
	    DoubleConsts.MIN_NORMAL,
	};

	for(int i =0; i < values.length; i++) {
	    System.out.println("0x" + Long.toHexString(Double.doubleToRawLongBits(values[i])) +
			       "\t0x" + Long.toHexString(Double.doubleToLongBits(values[i])) +
			       // "\t" + Double.toHexString(values[i]) +
			       "\t" + FpUtils.ilogb(values[i])
			       );
						       
	}

    }
}


(The ilogb failures are mislabled as float when they are actualy double input.)

Transferring bug to C2.

###@###.### 2003-07-31